Conversation
|
@syssi in the async code I've started working on (not much time recently to move it forward) I'm running discovery independently from the requests. It runs on timer every minute or so. There's also an async lock which keeps the command from running if library is waiting for discovery response. |
|
@rytilahti The lazy device discovery works fine for philips lights without drawbacks so far. Are you happy with the order of the init parameters? |
|
That looks fine for me (the "force discovery" was merely a hack to make it work after some FW update), but let me run this for a day or so on all my devices just to be sure. I'm not sure about the parameter order, but I think the lazy discovery should be set as @yawor iirc some miio protocol implementation (maybe it was the javascript one) used to do updates every 180 or 200 seconds. I'm unsure if they had any data to back that up though. Having an initial PR for async sounds good though! In a couple of weeks homeassistant will drop python 3.4 support, which probably will lead the way for dropping it also from this library (if @syssi is not too much against it :-)). |
I want to reduce the number of discovery messages of specific devices (Philips Lights).